Skip to content

Expose the Reader View button item on iOS#391

Merged
radazzouz merged 2 commits intomasterfrom
rad/readerViewButtonItem
Mar 9, 2021
Merged

Expose the Reader View button item on iOS#391
radazzouz merged 2 commits intomasterfrom
rad/readerViewButtonItem

Conversation

@radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Mar 8, 2021

Details

Kapture 2021-03-08 at 07 35 39

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: ae02732).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@aksh1t
Copy link

aksh1t commented Mar 9, 2021

Hmm... somehow I'm not able to give an approved review for this, getting a GitHub error.

Copy link

@aksh1t aksh1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aksh1t
Copy link

aksh1t commented Mar 9, 2021

Ok, worked now! Thanks for adding the gif!

@radazzouz radazzouz merged commit 272be92 into master Mar 9, 2021
@radazzouz radazzouz deleted the rad/readerViewButtonItem branch March 9, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments